Skip to content

Add decimal separator localization note to Part 5 (Working with SQL) tutorial#36945

Open
Copilot wants to merge 2 commits intomainfrom
copilot/add-localization-decimal-separator-note
Open

Add decimal separator localization note to Part 5 (Working with SQL) tutorial#36945
Copilot wants to merge 2 commits intomainfrom
copilot/add-localization-decimal-separator-note

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

Fixes #33793

Non-English locale users encounter a comma/dot decimal mismatch when editing the Price field in Part 5 of the First MVC App tutorial — the existing currency.md localization note only appeared in Part 9 (Validation), well after users first hit the issue.

Changes

  • Added [!INCLUDE[](~/includes/localization/currency.md)] after the seeded data screenshots and before the step-by-step nav block in all versioned include files:
    • working-with-sql.md (≥ aspnetcore-10.0)
    • includes/working-with-sql9.md
    • includes/working-with-sql8.md
    • includes/working-with-sql7.md
    • includes/working-with-sql6.md
    • includes/working-with-sql3-5.md
  • Updated ms.date in the main working-with-sql.md

Internal previews

📄 File 🔗 Preview link
aspnetcore/tutorials/first-mvc-app/working-with-sql.md aspnetcore/tutorials/first-mvc-app/working-with-sql

…tutorial files

Add [!INCLUDE[](~/includes/localization/currency.md)] after the seeded data screenshots
and before the step-by-step navigation block in all versioned working-with-sql include
files and the main article. This addresses the comma vs. dot decimal separator issue
that non-English locale users encounter when viewing/editing the Price field in Part 5,
before they reach Part 9 (Validation) where the note already existed.

Fixes #33793

Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/5100d3da-96fe-49ad-9fa6-a492fa0c700d

Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com>
Copilot AI changed the title [WIP] Add localization note for decimal separator in Part 5 Add decimal separator localization note to Part 5 (Working with SQL) tutorial Apr 3, 2026
Copilot AI requested a review from wadepickett April 3, 2026 01:38
@wadepickett wadepickett marked this pull request as ready for review April 3, 2026 01:53
@wadepickett wadepickett requested a review from Copilot April 3, 2026 01:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “First MVC App” tutorial (Part 5: Working with SQL) to surface an existing localization note earlier, helping non-English locale readers avoid decimal comma/decimal point input issues when editing the Price field.

Changes:

  • Added the existing currency/decimal-separator localization note include (~/includes/localization/currency.md) near the end of the Part 5 content across all versioned tutorial includes.
  • Added the same note to the >= aspnetcore-10.0 section of working-with-sql.md.
  • Updated ms.date in working-with-sql.md to 04/03/2026.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
aspnetcore/tutorials/first-mvc-app/working-with-sql.md Adds the localization note in the >= aspnetcore-10.0 content and updates ms.date.
aspnetcore/tutorials/first-mvc-app/working-with-sql/includes/working-with-sql9.md Adds the localization note include before the step-by-step navigation block.
aspnetcore/tutorials/first-mvc-app/working-with-sql/includes/working-with-sql8.md Adds the localization note include before the step-by-step navigation block.
aspnetcore/tutorials/first-mvc-app/working-with-sql/includes/working-with-sql7.md Adds the localization note include before the step-by-step navigation block.
aspnetcore/tutorials/first-mvc-app/working-with-sql/includes/working-with-sql6.md Adds the localization note include before the step-by-step navigation block.
aspnetcore/tutorials/first-mvc-app/working-with-sql/includes/working-with-sql3-5.md Adds the localization note include before the step-by-step navigation block.

@wadepickett wadepickett requested a review from tdykstra April 3, 2026 01:56
Copy link
Copy Markdown
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add localization/decimal separator note to Part 5 (Working with SQL) for non-English locales where comma vs. dot causes Price editing issues

3 participants